Re: [Xen-devel] [PATCH] xl.cfg: document the cpuid= option

[George Dunlap <dunlapg@xxxxxxxxx>]

On Fri, Jun 1, 2012 at 6:48 PM, Olaf Hering <olaf@xxxxxxxxx> wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@xxxxxxxxx>
> # Date 1338572607 -7200
> # Node ID 3da83ff08d6b6431c104a431d6617ccb5977643b
> # Parent  fde8ad0252ee6ddb8d71dda869db3b20b3d9ca62
> xl.cfg: document the cpuid= option
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
>
> diff -r fde8ad0252ee -r 3da83ff08d6b docs/man/xl.cfg.pod.5
> --- a/docs/man/xl.cfg.pod.5
> +++ b/docs/man/xl.cfg.pod.5
> @@ -969,9 +969,47 @@ XXX
>
>  XXX
>
> -=item B<cpuid=XXX>
> +=item B<cpuid="STRING"> or B<cpuid=[ "XEND_STRING", "XEND_STRING" ]>
>
> -XXX
> +Configure guest CPUID responses.

I think I would say, "Configure the value returned when a guest
executes CPUID instruction".  ("Response" is a technical term that
doesn't really seem to fit here, I think.)

> Two config versions of config syntax are
> +recognized: xend and libxl.

It's not clear from this text -- will libxl understand the xend format?

Other than that, the explanation and the example look really good.
(NB, I haven't reviewed for accuracy.)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel