Re: [Xen-devel] [PATCH V2] xs: set read_thread stacksize

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Simon Rowe writes ("[Xen-devel] [PATCH V2] xs: set read_thread stacksize"):
> xs_watch() creates a thread to wake watchers using default attributes. The
> stacksize can be quite large (8 MB on Linux), applications that link against
> xenstore end up having a larger memory footprint than necessary.

Thanks.  This seems like a genuine bug but I have one comments about
your fix.  The effect of your patch is to make the stacksize of the
libxenstore private thread be small.

However, we do not take any care to avoid signals being delivered to
this thread.  This is bad enough at the moment, but with your patch
these signals may now be delivered to a thread with a small stack.

Can I request that you provide another patch too, which would probably
come before this one, which uses pthread_sigprocmask to block all
signals on the private thread ?  This is done by changing the signal
mask to all signals blocked and then restoring it afterwards.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel