[Xen-devel] [PATCH 14/38] arm: do not set max_vcpus = 8 in arch_domain_create.

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

XEN_DOMCTL_max_vcpus cannot reduce max_vcpus and therefore we can't create a
smaller guest.

The limit of 8 (due to GIC limits) should be expressed elsewhere, likely in
MAX_VIRT_CPUS -- but making that change caused:
    (XEN) Unexpected Trap: Data Abort
    (XEN) ----[ Xen-4.2-unstable  x86_64  debug=y  Not tainted ]----
    (XEN) CPU:    0
    (XEN) PC:     00222e48 _spin_lock+0x28/0x6c
    (XEN) CPSR:   600001da MODE:HYP
    (XEN)      R0: 002c4389 R1: 800001da R2: 00000001 R3: 0000ffff
    (XEN)      R4: 002c4381 R5: 00000080 R6: 002c4380 R7: 002c4000
    (XEN)      R8: 002c4380 R9: 4000015a R10:00000080 R11:40017d6c R12:00000000
    (XEN)      SP: 40017d5c LR: 00222e34
    (XEN)
    [...]
    (XEN) Xen call trace:
    (XEN)    [<00222e48>] _spin_lock+0x28/0x6c
    (XEN)    [<0022623c>] init_timer+0xbc/0x160
    (XEN)    [<0021fbdc>] sched_init_vcpu+0x94/0x200
    (XEN)    [<002061a4>] alloc_vcpu+0x124/0x210
    (XEN)    [<00204890>] do_domctl+0xaa4/0x14e4
    (XEN)    [<00241ab8>] do_trap_hypervisor+0x588/0x8cc
    (XEN)    [<0023bbb0>] return_from_trap+0x0/0x4

so punt on that for now.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 xen/arch/arm/domain.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index bd900f9..e867cb2 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -215,8 +215,6 @@ int arch_domain_create(struct domain *d, unsigned int 
domcr_flags)
             goto fail;
     }
 
-    d->max_vcpus = 8;
-
     if ( (rc = domain_vgic_init(d)) != 0 )
         goto fail;
 
-- 
1.7.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel