Re: [Xen-devel] [PATCH 3 of 3] libxl: make it possible to explicitly specify default sched params

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH 3 of 3] libxl: make it possible to explicitly 
specify default sched params"):
> libxl: make it possible to explicitly specify default sched params

I think this API change is valuable and I would be willing to make a
freeze exception for it.  But I'd like to see George's comments on the
actual code.

> To do so we define a descriminating value which is never a valid
> real value for each parameter.

"Discriminating" would be the correct spelling but I think the word
"distinguished" would be more correct semantically.

> +#define LIBXL_SCHED_DOMAIN_PARAM_WEIGHT_DEFAULT    0
> +#define LIBXL_SCHED_DOMAIN_PARAM_CAP_DEFAULT       -1
> +#define LIBXL_SCHED_DOMAIN_PARAM_PERIOD_DEFAULT    0
> +#define LIBXL_SCHED_DOMAIN_PARAM_SLICE_DEFAULT     0
> +#define LIBXL_SCHED_DOMAIN_PARAM_LATENCY_DEFAULT   0
> +#define LIBXL_SCHED_DOMAIN_PARAM_EXTRATIME_DEFAULT -1

Is there some reason these can't all be -1 ?  The code has now happily
abstracted this away but anyone looking at one of these structs in a
debugger or trace log or something is going to be quite confused.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel