Re: [Xen-devel] [PATCH v6 05/11] libxl: introduce libxl__device_disk_add

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Stefano Stabellini writes ("[PATCH v6 05/11] libxl: introduce 
libxl__device_disk_add"):
> Introduce libxl__device_disk_add that takes an additional
> xs_transaction_t paramter.
> Implement libxl_device_disk_add using libxl__device_disk_add.

Can't this be done in such a way that the diff isn't "delete this
function completely" followed by "here is a new function" ?

I don't really understand why you want to move the function at all,
TBH.  I think keeping the public wrapper and the internal
implementation together is fine.  There is no need IMO to move the
internal function to libxl_internal.c.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel