Re: [Xen-devel] [PATCH 1 of 2] libxl: provide libxl_domain_config_init

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH 1 of 2] libxl: provide 
libxl_domain_config_init"):
> On Tue, 2012-04-24 at 18:58 +0100, Ian Jackson wrote:
> > Ian Campbell writes ("[Xen-devel] [PATCH 1 of 2] libxl: provide 
> > libxl_domain_config_init"):
> > > libxl: provide libxl_domain_config_init.
> > 
> > Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> Oops, I had an update which I'd forgotten to send out -- this is the
> delta, Sorry.

Ooops.

> libxl: use libxl_domain_config_init and not memset 0

Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

> I missed a couple of memsets in 25237:31489be80c51, we need to use
> libxl_domain_config_init everywhere and not memset since not all fields are
> initialised to zero now (the type field in particular). This fixes an abort
> with "xl list <dom>" for a specific domain due to assert(type == -1) in
> libxl_domain_build_info_init_type().

This will probably turn up as an automatic test failure.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel