Re: [Xen-devel] [PATCH] [RFC] xen: Fix memory hotplug end limit test for updating compat M2P table

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.04.12 at 18:02, Malcolm Crossley <malcolm.crossley@xxxxxxxxxx> wrote:
> The key fix is the patch is that epfn is being compared to 
> (RDWR_COMPAT_MPT_VIRT_END - RDWR_COMPAT_MPT_VIRT_START)
> without a 2 bit shift.

Ah, okay, that was well hidden among all the other changes you did,
and at least I wasn't able to decode this from the patch description.

> This means that epfn is being compared to the size of the RDWR_COMPAT_MPT 
> table instead of the maximum number of
> entries the RDWR_COMPAT_MPT table can contain. This could result in the end 
> regions of hotplugged memory being
> inaccessible when using the RDWR_COMPAT_MPT table.
> 
> I also moved the epfn masking to occur before the comparison to 
> RDWR_COMPAT_MPT to be consistent with the
> spfn comparison code.
> 
> I can split the patch for to make the changes clearer if you want?

I'm really not certain all the other changes really matter in any way,
so I'd really like to ask for a patch just adding the missing shift.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel