[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 4/8] libxl: introduce libxl__device_disk_add_t

Stefano Stabellini writes ("[Xen-devel] [PATCH v4 4/8] libxl: introduce 
> Introduce libxl__device_disk_add_t that takes an additional
> xs_transaction_t paramter.

Names ending "_t" are reserved for the implementation.  But you can
just call the internal function libxl__device_disk_add.  I think it's
fine to internal and external functions which differ only in _ and
parameters, provided that there is no nontrivial functionality in the
external function.

Apart from that it's rather hard to review because this patch seems to
have an awful lot of code motion mixed up with other changes.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.