Re: [Xen-devel] [PATCH v4 1/8] libxl: make libxl_device_disk_local_attach/detach internal functions

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-04-24 at 11:45 +0100, Stefano Stabellini wrote:

No functional change other than ctx->gc?

> diff --git a/tools/libxl/libxl_internal.c b/tools/libxl/libxl_internal.c
> index b89aef7..1f428b2 100644
> --- a/tools/libxl/libxl_internal.c
> +++ b/tools/libxl/libxl_internal.c
> @@ -323,6 +323,78 @@ out:
>      return rc;
>  }
>  
> +_hidden char * libxl__device_disk_local_attach(libxl__gc *gc, 
> libxl_device_disk *disk)

Strictly the hidden is only needed on the prototype. I guess there's no
harm having it here too (but you know what linkers are like...)

> +{
[...]
> +}

Looking at the callers this could possibly be a gc'd string, and perhaps
const in the return here. That's for another day though I think.

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel