Re: [Xen-devel] [PATCH 18/24] libxl: make libxl_create run bootloader via callback

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH 18/24] libxl: make libxl_create 
run bootloader via callback"):
> On Mon, 2012-04-16 at 18:18 +0100, Ian Jackson wrote:
> > Change initiate_domain_create to properly use libxl__bootloader_run
> > rather than improperly calling libxl_run_bootloader with NULL ao_how.
> > 
> > Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thanks.

> [...]
> > +    /* convenience aliases */
> > +    uint32_t domid = dcs->guest_domid;
> > +    libxl_domain_config *d_config = dcs->guest_config;
> > +    int restore_fd = dcs->restore_fd;
> >      libxl__domain_build_state *state = &dcs->build_state;
> > +    libxl_ctx *ctx = CTX;
> 
> I commented on a previous patch about const in these blocks of
> "convenience aliases" and I think you were going to scope them all out,
> but since there has been a bit of a gap in my review of this series I
> might as well mention it again.

I will arrange to constify them all.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel