Re: [Xen-devel] [PATCH] Re: Shadow domains left zombie

[Tim Deegan <tim@xxxxxxx>]

At 08:59 +0100 on 20 Apr (1334912349), Jan Beulich wrote:
> >>> On 19.04.12 at 19:08, Tim Deegan <tim@xxxxxxx> wrote:
> > At 09:19 -0700 on 13 Apr (1334308772), Andres Lagar-Cavilla wrote:
> >> After a hvm+shadow domain dies (either clean shutdown or merciless
> >> destroy), the domain is left in a zombie state with 1 (one) page left
> >> dangling with a single reference.
> > 
> > The reference is to the top-level pagetable that was pointed to by CR3
> > when the domain was killed.  This bug came in with:
> > 
> >  changeset:   23142:f5e8d152a565
> >  user:        Jan Beulich <jbeulich@xxxxxxxxxx>
> >  date:        Tue Apr 05 13:01:25 2011 +0100
> >  description: x86: split struct vcpu
> > 
> > where HVM domains no longer have vcpu_destroy_pagetables(v) called on
> > their VCPUs as they die.  Proposed fix attached.
> 
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> I'm sorry for that. Given that this had been quite some time back, I
> can only guess that I got misguided by the fact that
> arch_vcpu_reset() calls this for PV only (legitimately, i.e. not causing
> any leak).

Yeah, it's not exactly clear.  Maybe after 4.2 I'll look at making it
more uniform.

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel