Re: [Xen-devel] [PATCH v2 4/5] libxl: call hotplug scripts from libxl for vif

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

> >> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> >> index 01ff363..41230a6 100644
> >> --- a/tools/libxl/xl_cmdimpl.c
> >> +++ b/tools/libxl/xl_cmdimpl.c
> >> @@ -846,6 +846,19 @@ static void parse_config_data(const char 
> >> *configfile_filename_report,
> >>              nic->script = strdup(default_vifscript);
> >>          }
> >>
> >> +            /* Set default nic type for PV guests correctly */
> >> +            if (b_info->type == LIBXL_DOMAIN_TYPE_PV) {
> >> +                nic->nictype = LIBXL_NIC_TYPE_VIF;
> >> +            }
> >
> > Hrm, really the lib ought to be taking care of that for us...
> >
> > libxl__device_nic_setdefault has a domid so it should be able to query
> > the domain type with libxl__domain_type.
> 
> int libxl__device_nic_setdefault(libxl__gc *gc, libxl_device_nic *nic) 
> is the prototype, and libxl_device_nic doesn't have a domid, so I'm not 
> sure where should I get it from.

Urk, oh dear.

I think it would be ok to add parameters which are necessary for
setdefault to make its decision.

Other wise perhaps make the default be LIBXL_NIC_TYPE_VIF
unconditionally? That is the option which has a chance of working
regardless of guest type, TYPE_IOEMU is a bit of an odd choice for the
default.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel