Re: [Xen-devel] [PATCH] Makefile: Some updates to uninstall

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-04-16 at 12:45 +0100, Fabio Fantoni wrote:
> # HG changeset patch
> # User Fabio Fantoni
> # Date 1334565174 -7200
> # Node ID a9c00a9b48c708a8e448bf5d9cd96026721fbf2f
> # Parent  6b72eb3b40cf2b3d5a6c75d68fa7093c57fc0d1f
> Makefile: Some updates to uninstall
> 
> Signed-off-by: Fabio Fantoni <fabio.fantoni@xxxxxxxxxx>
> 
> diff -r 6b72eb3b40cf -r a9c00a9b48c7 Makefile
> --- a/Makefile    ven apr 13 17:13:01 2012 +0100
> +++ b/Makefile    lun apr 16 10:32:54 2012 +0200
> @@ -220,13 +220,12 @@
>   uninstall: D=$(DESTDIR)
>   uninstall:
>       [ -d $(D)$(XEN_CONFIG_DIR) ] && mv -f $(D)$(XEN_CONFIG_DIR) 
> $(D)$(XEN_CONFIG_DIR).old-`date +%s` || true
> -    rm -rf $(D)$(CONFIG_DIR)/init.d/xend*
> +    rm -rf $(D)$(CONFIG_DIR)/init.d/xen*

I know this is pre-existing but I'd rather see these enumerating all the
actual possibilities without wildcards, so as to not remove any local
initscripts which might happen to match (which becomes move likely with
your removal of the "d")

>       rm -rf $(D)$(CONFIG_DIR)/hotplug/xen-backend.agent
>       rm -f  $(D)$(CONFIG_DIR)/udev/rules.d/xen-backend.rules
> -    rm -f  $(D)$(CONFIG_DIR)/udev/xen-backend.rules
>       rm -f  $(D)$(CONFIG_DIR)/udev/rules.d/xend.rules
> -    rm -f  $(D)$(CONFIG_DIR)/udev/xend.rules

These two are things older versions of Xen installed but which current
versions do not?

>       rm -f  $(D)$(SYSCONFIG_DIR)/xendomains
> +    rm -f  $(D)$(SYSCONFIG_DIR)/xencommons
>       rm -rf $(D)/var/run/xen* $(D)/var/lib/xen*
>       rm -rf $(D)/boot/*xen*
>       rm -rf $(D)/lib/modules/*xen*
> @@ -236,11 +235,16 @@
>       rm -rf $(D)$(BINDIR)/pygrub
>       rm -rf $(D)$(BINDIR)/setsize $(D)$(BINDIR)/tbctl
>       rm -rf $(D)$(BINDIR)/xsls
> -    rm -rf $(D)$(INCLUDEDIR)/xenctrl.h $(D)$(INCLUDEDIR)/xenguest.h
> +    rm -rf $(D)$(BINDIR)/xenstore* $(D)$(BINDIR)/xentrace*
> +    rm -rf $(D)$(BINDIR)/xen-detect $(D)$(BINDIR)/xencons
> +    rm -rf $(D)$(BINDIR)/xenpvnetboot $(D)$(BINDIR)/qemu-*-xen
> +    rm -rf $(D)$(INCLUDEDIR)/xenctrl* $(D)$(INCLUDEDIR)/xenguest.h
>       rm -rf $(D)$(INCLUDEDIR)/xs_lib.h $(D)$(INCLUDEDIR)/xs.h
>       rm -rf $(D)$(INCLUDEDIR)/xen
> +    rm -rf $(D)$(INCLUDEDIR)/_libxl* $(D)$(INCLUDEDIR)/libxl*
> +    rm -rf $(D)$(INCLUDEDIR)/xenstat.h $(D)$(INCLUDEDIR)/xentoollog.h
>       rm -rf $(D)$(LIBDIR)/libxenctrl* $(D)$(LIBDIR)/libxenguest*
> -    rm -rf $(D)$(LIBDIR)/libxenstore*
> +    rm -rf $(D)$(LIBDIR)/libxenstore* $(D)$(LIBDIR)/libxlutil*
>       rm -rf $(D)$(LIBDIR)/python/xen $(D)$(LIBDIR)/python/grub
>       rm -rf $(D)$(LIBDIR)/xen/
>       rm -rf $(D)$(LIBEXEC)/xen*
> @@ -248,6 +252,7 @@
>       rm -rf $(D)$(SBINDIR)/xen* $(D)$(SBINDIR)/netfix $(D)$(SBINDIR)/xm
>       rm -rf $(D)$(SHAREDIR)/doc/xen
>       rm -rf $(D)$(SHAREDIR)/xen
> +    rm -rf $(D)$(SHAREDIR)/qemu-xen
>       rm -rf $(D)$(MAN1DIR)/xen*
>       rm -rf $(D)$(MAN8DIR)/xen*
>       rm -rf $(D)/boot/tboot*
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel