Re: [Xen-devel] [PATCH 04/20] autoconf: New test for openpty et al.

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

El 13/04/2012, a las 19:39, Ian Jackson escribió:
> We may need to #include <libutil.h>, and/or link with -lutil, to use
> openpty, login_tty, and the like.  Provide INCLUDE_LIBUTIL_H
> (preprocessor constant, not always defined) and PTYFUNCS_LIBS
> (makefile variable).
> 
> We link libxl against PTYFUNCS_LIBS (which comes from autoconf) rather
> than UTIL_LIBS, and #include <libutil.h> where appropriate.
> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> ---
> config/Tools.mk.in             |    2 +
> tools/configure                |   51 ++++++++++++++++++++++++++++++++++++++++
> tools/configure.ac             |    2 +
> tools/libxl/Makefile           |    2 +-
> tools/libxl/libxl_bootloader.c |    4 +++
> tools/m4/ptyfuncs.m4           |   24 ++++++++++++++++++
> 6 files changed, 84 insertions(+), 1 deletions(-)
> create mode 100644 tools/m4/ptyfuncs.m4
> 
> diff --git a/tools/libxl/libxl_bootloader.c b/tools/libxl/libxl_bootloader.c
> index 2774062..b50944a 100644
> --- a/tools/libxl/libxl_bootloader.c
> +++ b/tools/libxl/libxl_bootloader.c
> @@ -16,6 +16,10 @@
> 
> #include <termios.h>
> 
> +#ifdef INCLUDE_LIBUTIL_H
> +#include INCLUDE_LIBUTIL_H
> +#endif
> +

Maybe I'm missing something, because this autoconf macros are hard to read, but 
shouldn't you add something like

#undef INCLUDE_LIBUTIL_H

to tools/config.h.in, so the generated config.h contains this define?

> #include "libxl_internal.h"
> 
> #define XENCONSOLED_BUF_SIZE 16



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel