[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] libxl/build: print a pretty message if flex/bison are needed but not found

This patchs adds better support for both Flex and Bison, which might be needed
to compile libxl. Now configure script sets BISON and FLEX Makefile vars if
bison and flex are found, but doesn't complain if they are not found.

Also, added some Makefile soccery to print a nice error message if Bison or Flex
are needed but not found.

Please run autogen after applying this patch.

Signed-off-by: Roger Pau Monne <roger.pau@xxxxxxxxxx>
Cc: zhihao wang <accept.acm@xxxxxxxxx>
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
 tools/configure.ac   |    2 ++
 tools/libxl/Makefile |   16 ++++++++++++++--
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/tools/configure.ac b/tools/configure.ac
index 3da0c82..8ccdc92 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -75,6 +75,8 @@ AC_PROG_CC
+AC_PATH_PROG([BISON], [bison])
+AC_PATH_PROG([FLEX], [flex])
 AS_IF([test "x$xapi" = "xy"], [
     AX_PATH_PROG_OR_FAIL([CURL], [curl-config])
diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index ac8b810..e8ec8e9 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -48,6 +48,18 @@ please check libxl_linux.c and libxl_netbsd.c to see how to 
get it ported)
+ifeq ($(FLEX),)
+%.c %.h:: %.l
+       $(error Flex is needed to compile libxl, please install it and rerun \
+       configure)
+ifeq ($(BISON),)
+%.c %.h:: %.y
+       $(error Bison is needed to compile libxl, please install it an rerun \
+       configure)
 LIBXL_LIBS += -lyajl
 LIBXL_OBJS = flexarray.o libxl.o libxl_create.o libxl_dm.o libxl_pci.o \
@@ -83,11 +95,11 @@ all: $(CLIENTS) libxenlight.so libxenlight.a libxlutil.so 
libxlutil.a \
-%.c %.h: %.y
+%.c %.h:: %.y
        @rm -f $*.[ch]
        $(BISON) --output=$*.c $<
-%.c %.h: %.l
+%.c %.h:: %.l
        @rm -f $*.[ch]
        $(FLEX) --header-file=$*.h --outfile=$*.c $<
-- (Apple Git-26)

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.