Re: [Xen-devel] [PATCH v6 1/3] libxc: introduce XC_SAVE_ID_TOOLSTACK

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 3 Apr 2012, Ian Jackson wrote:
> Stefano Stabellini writes ("[Xen-devel] [PATCH v6 1/3] libxc: introduce 
> XC_SAVE_ID_TOOLSTACK"):
> > Introduce a new save_id to save/restore toolstack specific extra
> > information.
> 
> This looks plausible.
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> Although I do have one comment: are you sure it's appropriate that the
> "toolstack data" is silently thrown away if the restore caller doesn't
> supply the relevant callback ?

We should print a warning in that case and try to continue

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel