Re: [Xen-devel] [PATCH 3 of 6] x86/mm: Another couple of comparisons of unsigned vars with < 0

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.04.12 at 14:07, Tim Deegan <tim@xxxxxxx> wrote:
> # HG changeset patch
> # User Tim Deegan <tim@xxxxxxx>
> # Date 1333626954 -3600
> # Node ID 5eeaa7b25a60327c48bf17472e9a00bdfc67378f
> # Parent  0ecf439475e12f185553f42f56f099be5f328cce
> x86/mm: Another couple of comparisons of unsigned vars with < 0.
> 
> Adding the explicit (unsigned) casts in case enums ever end up signed.

Ugly, but unavoidable if range comparisons are done on enums (which
is what ought to get fixed instead imo).

Jan

> Signed-off-by: Tim Deegan <tim@xxxxxxx>
> 
> diff -r 0ecf439475e1 -r 5eeaa7b25a60 xen/arch/x86/mm/p2m.c
> --- a/xen/arch/x86/mm/p2m.c   Thu Apr 05 12:55:54 2012 +0100
> +++ b/xen/arch/x86/mm/p2m.c   Thu Apr 05 12:55:54 2012 +0100
> @@ -1305,7 +1305,7 @@ int p2m_set_mem_access(struct domain *d,
>          p2m->default_access,
>      };
>  
> -    if ( access >= HVMMEM_access_default || access < 0 )
> +    if ( (unsigned) access >= HVMMEM_access_default )
>          return -EINVAL;
>  
>      a = memaccess[access];
> @@ -1367,7 +1367,7 @@ int p2m_get_mem_access(struct domain *d,
>      if ( mfn_x(mfn) == INVALID_MFN )
>          return -ESRCH;
>      
> -    if ( a >= ARRAY_SIZE(memaccess) || a < 0 )
> +    if ( (unsigned) a >= ARRAY_SIZE(memaccess) )
>          return -ERANGE;
>  
>      *access =  memaccess[a];
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx 
> http://lists.xen.org/xen-devel 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel