Re: [Xen-devel] [PATCH 5 of 6] xend/xc: Implement a domain_set_e820_hole function to be used by python code

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-04-02 at 16:59 +0100, Konrad Rzeszutek Wilk wrote:
> On Mon, Mar 26, 2012 at 10:42:59AM +0100, Ian Campbell wrote:
> > 
> > > +static const char *e820_names(int type)
> > > +{
> > > +    switch (type) {
> > > +        case E820_RAM: return "RAM";
> > > +        case E820_RESERVED: return "Reserved";
> > > +        case E820_ACPI: return "ACPI";
> > > +        case E820_NVS: return "ACPI NVS";
> > > +        case E820_UNUSABLE: return "Unusable";
> > > +        default: break;
> > > +    }
> > > +    return "Unknown";
> > > +}
> > > +#endif
> > > +static int e820_sanitize(struct e820entry src[],
> > > +                         uint32_t *nr_entries,
> > > +                         unsigned long map_limitkb,
> > > +                         unsigned long balloon_kb)
> > > +{
> > 
> > Seems odd to do this in the C bindings, can this be done either in the
> > python layer or in the libxc layer (in which case libxl can use it too?)
> 
> So this is copied from the libxl layer (With the removal of the
> libxl_ctx). I was hoping you could shed some ideas of how to "export" that
> function (e820_sanitize) from the libxl_pci.c so that the
> tools/python/xen/lowlevel/xc/xc.c can also use it?

The only way would be to move this functionality into libxc instead of
libxl.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel