Re: [Xen-devel] [PATCH 2 of 2] xl, libxl: Add per-device and global permissive config options for pci passthrough

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

George Dunlap writes ("Re: [Xen-devel] [PATCH 2 of 2] xl, libxl: Add per-device 
and global permissive config options for pci passthrough"):
> I'm not sure how we can make it more definite.  What's possible (i.e., 
> the security implications) entirely depends on the card; and what's 
> likely (i.e., the stability implications) entirely depends on the card 
> and the driver.  Short of giving a short discourse on the vices of 
> various cards PCI config space (which is entirely inappropriate for a 
> man page, IMHO), I'm not sure what more we can say.

Is it generally or usually the case that this option will more
completely expose the host ?

> I thought it was unnecessary to duplicate, but I can do so if you prefer.

I guess that depends on how strong a statement it is.

> > I think you should consider breakibg out the sysfs writing function
> > and refactoring with the very similar code in libxl__device_pci_reset,
> > rather than introducing yet another clone.
>
> I shall consider it. :-)

Thanks :-).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel