Re: [Xen-devel] [PATCH 2 of 2] xl, libxl: Add per-device and global permissive config options for pci passthrough

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

> >> diff -r 5386937e6c5c -r 62b1030a2485 tools/libxl/libxl_pci.c
> >> --- a/tools/libxl/libxl_pci.c      Mon Apr 02 11:29:34 2012 +0100
> >> +++ b/tools/libxl/libxl_pci.c      Mon Apr 02 11:45:00 2012 +0100
> >> @@ -55,7 +55,10 @@ static void libxl_create_pci_backend_dev
> >>       if (pcidev->vdevfn)
> >>           flexarray_append_pair(back, libxl__sprintf(gc, "vdevfn-%d", 
> >> num), libxl__sprintf(gc, "%x", pcidev->vdevfn));
> >>       flexarray_append(back, libxl__sprintf(gc, "opts-%d", num));
> >> -    flexarray_append(back, libxl__sprintf(gc, 
> >> "msitranslate=%d,power_mgmt=%d", pcidev->msitranslate, 
> >> pcidev->power_mgmt));
> >> +    flexarray_append(back,
> >> +              libxl__sprintf(gc, 
> >> "msitranslate=%d,power_mgmt=%d,permissive=%d",
> >> +                             pcidev->msitranslate, pcidev->power_mgmt,
> >> +                             pcidev->permissive));
> > Since we are already writing this key, and AFAICT this matches xend's
> > behaviour, I think it is correct to add the new parameter here. But...
> >
> > Does anything actually read this key? I can't find anything in pciback
> > or qemu.
> No idea -- I was just following suit.  In any case, it's probably not a 
> bad idea to have this kind of thing in there to help debug stuff.
> 
> Let me know if you want to do something else, otherwise I'll keep it in 
> for my next patch series.

It's fine, I was just wondering if anyone knew what it was for.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel