Re: [Xen-devel] [PATCH] libxl: use qemu-xen with PV guests by default

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-03-23 at 14:52 +0000, Stefano Stabellini wrote:
> qemu-xen offers better disk performances than qemu-xen-traditional
> because it supports Linux native AIO.

The qemu-upstream test flights are failing far more often than not. In
fact I expect the *single* pass (actually a "tolerable fail") we've ever
had was actually a fluke. Is qemu-xen really ready to be used in this
way?

Ian.

> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> ---
>  tools/libxl/libxl_create.c |   11 ++++++++---
>  1 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> index 8417661..dbff02c 100644
> --- a/tools/libxl/libxl_create.c
> +++ b/tools/libxl/libxl_create.c
> @@ -71,9 +71,14 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
>          b_info->type != LIBXL_DOMAIN_TYPE_PV)
>          return ERROR_INVAL;
>  
> -    if (!b_info->device_model_version)
> -        b_info->device_model_version =
> -            LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL;
> +    if (!b_info->device_model_version) {
> +        if (b_info->type == LIBXL_DOMAIN_TYPE_HVM)
> +            b_info->device_model_version =
> +                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL;
> +        else
> +            b_info->device_model_version =
> +                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN;
> +    }
>  
>      if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
>          if (!b_info->u.hvm.bios)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel