[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/hpet: simplify hpet_get_channel()

  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxx>
  • Date: Fri, 23 Mar 2012 15:05:32 +0000
  • Cc: Gang Wei <gang.wei@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxx>
  • Delivery-date: Fri, 23 Mar 2012 15:06:03 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>
  • Thread-index: Ac0JBmRAbXWOGTZMJ0epNxjXMHUiUg==
  • Thread-topic: [Xen-devel] [PATCH] x86/hpet: simplify hpet_get_channel()

On 23/03/2012 14:40, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>> Does that matter? It's the last thing done before going into deep sleep.
>> I suppose I don't mind that much, the whole thing just seems to make the C
>> code longer.
> Okay, let's forget about it then. (I could certainly make the code
> shorter using a few comma expressions, but I don't think you'd
> like that any better.)

Not really!

Getting rid of the lock and using cmpxchg, and making next_channel have the
right meaning all makes sense. So a patch that just replaced the locked
region, but didn't touch the following for-loop, would make sense to me. You
can consider that Acked if you want to apply it.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.