Re: [Xen-devel] [PATCH] x86/hpet: simplify hpet_get_channel()

[Keir Fraser <keir@xxxxxxx>]

On 23/03/2012 10:46, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>> Why is the following for-loop changed into do-while? It looks like it just
>> makes the code longer, especially as you replace a % operator with
>> open-coded equivalent for no reason I can see.
> 
> Simply because
> 
>     for ( i = next; i != next; ++i )
> 
> makes no sense.
> 
> Removing the % is an efficiency thing - the resulting code is not only
> faster, but also smaller (presumably because of the special register
> limitations div has).

Does that matter? It's the last thing done before going into deep sleep.

I suppose I don't mind that much, the whole thing just seems to make the C
code longer.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel