Re: [Xen-devel] [PATCH 05/11] device tree: add device_tree_for_each_node()

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-03-19 at 17:52 +0000, David Vrabel wrote:
> +    for ( node = 0, depth = 0;
> +          node >=0 && depth >= 0;
> +          node = fdt_next_node(fdt, node, &depth) )
> +    {
> +        if ( depth >= MAX_DEPTH )
> +            continue;

Perhaps we should fail and return an error here (which the caller can
log with whatever facilities are available, e.g. early_printk or
printk)? Silently just not walking a bit of the tree seem liable to lead
to odd errors...

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel