Re: [Xen-devel] [PATCH 2 of 4] xl: xl network-attach -N (dry run) option

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-03-20 at 01:28 +0000, Mathieu Gagnà wrote:
> Add dryrun for testing and debugging purposes.
> 
> Signed-off-by: Mathieu Gagnà <mgagne@xxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> 
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -4756,6 +4756,16 @@ int main_networkattach(int argc, char **
>              return 1;
>          }
>      }
> +
> +    if (dryrun_only) {
> +        char *json = libxl_device_nic_to_json(ctx, &nic);
> +        printf("vif: %s\n", json);
> +        free(json);
> +        libxl_device_nic_dispose(&nic);
> +        if (ferror(stdout) || fflush(stdout)) { perror("stdout"); exit(-1); }
> +        return 0;
> +    }
> +
>      if (libxl_device_nic_add(ctx, domid, &nic)) {
>          fprintf(stderr, "libxl_device_nic_add failed.\n");
>          return 1;
> diff --git a/tools/libxl/xl_cmdtable.c b/tools/libxl/xl_cmdtable.c
> --- a/tools/libxl/xl_cmdtable.c
> +++ b/tools/libxl/xl_cmdtable.c
> @@ -279,7 +279,7 @@ struct cmd_spec cmd_table[] = {
>        "",
>      },
>      { "network-attach",
> -      &main_networkattach, 0,
> +      &main_networkattach, 1,
>        "Create a new virtual network device",
>        "<Domain> [type=<type>] [mac=<mac>] [bridge=<bridge>] "
>        "[ip=<ip>] [script=<script>] [backend=<BackDomain>] [vifname=<name>] "
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel