[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4 of 4] unmodified_drivers: compile vcd.c into blkfront if available

>>> On 16.03.12 at 08:48, Olaf Hering <olaf@xxxxxxxxx> wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@xxxxxxxxx>
> # Date 1331883708 -3600
> # Node ID 321e3ada9b40a0b164ac617f26d254fc3354c024
> # Parent  d721480672b9686011cef0965cefd81a969277b0
> unmodified_drivers: compile vcd.c into blkfront if available
> The forward ported xenlinux sources in openSuSE have a PV CDROM driver
> since a long time. Detect the presence of this driver and compile it
> into the xen_vbd module.
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> diff -r d721480672b9 -r 321e3ada9b40 
> unmodified_drivers/linux-2.6/blkfront/Kbuild
> --- a/unmodified_drivers/linux-2.6/blkfront/Kbuild
> +++ b/unmodified_drivers/linux-2.6/blkfront/Kbuild
> @@ -3,3 +3,4 @@ include $(M)/overrides.mk
>  obj-m += xen-vbd.o
>  xen-vbd-objs := blkfront.o vbd.o
> +xen-vbd-objs += $(patsubst %.c,%.o,$(notdir $(wildcard $(src)/vcd.c)))

This is an entirely Novell/SuSE-only thing, we shouldn't bother
upstream with that (unless someone decides to upstream the base
kernel code too, which seems pointless for the old tree). Further
more, just last week I eliminated the need for compiling this file
when building the pv drivers (the change above will need to be
dropped from our patches once the kernel side change gets
submitted to the build system), largely because we don't allow
blkfront to handle CDs anyway (see the master branch's
current patches.xen/xen-blkfront-hvm-no-cdrom).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.