[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 0 of 6] [RFC] Use wait queues for paging, v2

At 20:56 +0100 on 29 Feb (1330548983), Olaf Hering wrote:
> On Wed, Feb 29, Olaf Hering wrote:
> > This is the domain_lock() in xenmem_add_to_physmap_once(). 
> > 
> > Is get_gfn_untyped() correct, or would get_gfn_query() work as well in
> > this context?

get_gfn_untyped() is correct.  I'm not sure that we really need to take
the domain lock while we're doing it, though.  It might be that the new
gfn locks will be enough to serialize these updates.

> Another case is emulate_privileged_op(), in "Write CR3" case
> get_gfn_untyped() is called with domain_lock().

I think that should be OK as it only happens for PV guests. 

> Same for XENMEM_remove_from_physmap.

That can almost certainly be done without the domain lock.

Sadly I haven't got time to fix these all up today.  
I have committed patches 1 to 4 of this series, and made some of the
changes suggested to the other two but there seems little point in
reposting them until we can sort out the locking. 

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.