Re: [Xen-devel] [PATCH] autoconf: change AX_ARG_{DISABLE/ENABLE}_AND_EXPORT to make more sense

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-03-15 at 11:19 +0000, Roger Pau Monnà wrote:
> 2012/3/15 Olaf Hering <olaf@xxxxxxxxx>:
> > On Thu, Feb 23, Roger Pau Monne wrote:
> >
> >> diff -r 64f5cd4aa2a2 -r 18fea25a3f0c tools/configure
> >> --- a/tools/configure Tue Mar 13 17:30:50 2012 +0000
> >> +++ b/tools/configure Thu Feb 23 06:45:51 2012 +0100
> >> @@ -1371,7 +1371,7 @@ Optional Features:
> >>    --disable-ocamltools    Disable Ocaml tools
> >>    --enable-miniterm       Enable miniterm
> >>    --enable-lomount        Enable lomount
> >> -  --disable-debug         Disable debug build of tools
> >> +  --disable-debug         Disable debug build of Xen and tools
> >
> > This was what actually confused me. I expected to see what the default
> > is in the 'configure --help' output because I think thats what I have
> > seen in the past from other projects. But I have to double check wether
> > other projects really do it that way or if I just interpreted it that
> > way.
> 
> What we could actually do is provide both options, something like:
> 
> --disable-debug         disable debug build of tools
> --enable-debug          enable debug build of tools (default)
> 
> What do you think about this?

We should do whatever everyone else does or follow whatever guidelines
autoconf make.

http://www.delorie.com/gnu/docs/autoconf/autoconf_132.html seems to
suggest that
        --disable-deb    disable debug build (default is YES)
is the way to go.


http://www.flameeyes.eu/autotools-mythbuster/autoconf/arguments.html
appears to concur that you provide the help text for the option which is
the opposite of the default (which makes sense to me). I don't know how
authoritative that doc is though.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel