Re: [Xen-devel] [PATCH] [PATCH v3] Fetch the OVMF repository from specific git mirror and enable it

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-03-01 at 19:28 +0000, Attilio Rao wrote:

> +subdir-distclean-ovmf: .phony
> +     rm -rf ovmf ovmf-remote
> +

I think you also want a "subdir-clean-ovmf" which does:
        set -e; if test -d ovmf-dir/.; then \
                $(MAKE) -C ovmf-dir clean; \
        fi
in order that make clean on a clean tree works.

SeaBIOS is also lacking this, see below:

8<--------------------------------------------------

# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1331730567 0
# Node ID 09de1fcd7acb3d07ee40d2aebbf7b0b0f18a516f
# Parent  20c8a7db63d160e95fcf5c8e2f9d31923d336316
tools: Add explicit clean rule for SeaBIOS

Since seabios-dir is cloned during build we need to check that it exists before
recursing into it for clean, following the pattern used for qemu-*-dir etc.

Also remove usage of "buildmakevars2shellvars" except when used to poopulate
the environment for qemu-xen-traditional's xen-setup script, which is the only
user.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r 20c8a7db63d1 -r 09de1fcd7acb tools/Makefile
--- a/tools/Makefile    Wed Mar 14 11:40:44 2012 +0000
+++ b/tools/Makefile    Wed Mar 14 13:09:27 2012 +0000
@@ -127,7 +127,6 @@ subdir-all-qemu-xen-traditional-dir subd
 
 subdir-clean-qemu-xen-traditional-dir:
        set -e; if test -d qemu-xen-traditional-dir/.; then \
-               $(buildmakevars2shellvars); \
                $(MAKE) -C qemu-xen-traditional-dir clean; \
        fi
 
@@ -162,7 +161,6 @@ subdir-all-qemu-xen-dir subdir-install-q
 
 subdir-clean-qemu-xen-dir:
        set -e; if test -d qemu-xen-dir/.; then \
-               $(buildmakevars2shellvars); \
                $(MAKE) -C qemu-xen-dir clean; \
        fi
 
diff -r 20c8a7db63d1 -r 09de1fcd7acb tools/firmware/Makefile
--- a/tools/firmware/Makefile   Wed Mar 14 11:40:44 2012 +0000
+++ b/tools/firmware/Makefile   Wed Mar 14 13:09:27 2012 +0000
@@ -55,3 +55,8 @@ seabios-dir-force-update:
                $(GIT) fetch origin; \
                $(GIT) reset --hard $(SEABIOS_UPSTREAM_TAG); \
        fi
+
+subdir-clean-seabios-dir:
+       set -e; if test -d seabios-dir/.; then \
+               $(MAKE) -C seabios-dir clean; \
+       fi



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel