[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools: Reorder and add includes in libvchan

On Tue, 2012-03-13 at 16:36 +0000, George Dunlap wrote:
> On Tue, 2012-03-13 at 16:30 +0000, Ian Jackson wrote:
> > George Dunlap writes ("[Xen-devel] [PATCH] tools: Reorder and add includes 
> > in libvchan"):
> > > libxenvchan.h includes xen/sys/evtchn.h, which in the XenServer patchqueue
> > > may contain domid_t values.  Just re-order the order of includes to make 
> > > sure
> > > that Xen-defined values make sense to the compiler.
> > 
> > Surely this should be fixed by having (XenServer's) evtchn.h include
> > xen.h itself ?
> Well, that's what I thought, but it's not what ijc thought (IIRC).

I can't remember that, but that's probably just me being forgetful
and/or I've not made the link between that conversation and this patch.

What is the related patch which adds the domid's to evtchn.h? Are we
going to see it upstream at some point too?

I notice that upstream tools/include/xen-sys/Linux/evtchn.h (which I
presume to be the header in question) uses "unsigned int" for the
various domain ids which it contains. ISTM that either a) XS should use
"unsigned int" too or b) they should be domid_t in upstream too.

I expect s/unsigned int/domid_t/ == an ABI change so I think only "a)"
is actually an option, although maybe "b)" is an option if you are
careful/clever with the padding.

>   I'm
> not really fussed either way, as long as I can get this patch out of the
> patchqueue.  Just let me know what you guys want.
>  -George

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.