Re: [Xen-devel] [PATCH 2 of 2] libxl: publish number of shared and paged pages

["Andres Lagar-Cavilla" <andres@xxxxxxxxxxxxxxxx>]

> On Mon, 2012-03-12 at 19:53 +0000, Andres Lagar-Cavilla wrote:
>> tools/libxl/libxl.c         |  3 ++-
>>  tools/libxl/libxl_types.idl |  1 +
>>  2 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> This is information is currently not harvested from libxc.
>>
>> Signed-off-by: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
>>
>> diff -r 94ec84eeca5d -r a17bd526989d tools/libxl/libxl.c
>> --- a/tools/libxl/libxl.c
>> +++ b/tools/libxl/libxl.c
>> @@ -459,7 +459,8 @@ static void xcinfo2xlinfo(const xc_domai
>>          xlinfo->shutdown_reason  = ~0;
>>
>>      xlinfo->current_memkb = PAGE_TO_MEMKB(xcinfo->tot_pages);
>> -    /* xlinfo->shared_memkb = PAGE_TO_MEMKB(xcinfo->shr_pages); */
>> +    xlinfo->shared_memkb = PAGE_TO_MEMKB(xcinfo->shr_pages);
>
> Same comment about not being commented out in xen-unstable. The other
> bits of this patch appear to make sense though.

I think the most accurate description for these two patches is "brain fart"

Here is the libxl patch, rebased.
Thanks
Andres

# HG changeset patch
# User Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
# Date 1331648207 14400
# Node ID 94b89a5f14e512c2ad46ef9ad1628fba19858463
# Parent  5d20d2f6ffed0a49f030f04a8870f1926babbcbf
libxl: publish number of paged pages.

This is information is currently not harvested from libxc.

Signed-off-by: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>

diff -r 5d20d2f6ffed -r 94b89a5f14e5 tools/libxl/libxl.c
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -460,6 +460,7 @@ static void xcinfo2xlinfo(const xc_domai

     xlinfo->current_memkb = PAGE_TO_MEMKB(xcinfo->tot_pages);
     xlinfo->shared_memkb = PAGE_TO_MEMKB(xcinfo->shr_pages);
+    xlinfo->paged_memkb = PAGE_TO_MEMKB(xcinfo->paged_pages);
     xlinfo->max_memkb = PAGE_TO_MEMKB(xcinfo->max_pages);
     xlinfo->cpu_time = xcinfo->cpu_time;
     xlinfo->vcpu_max_id = xcinfo->max_vcpu_id;
diff -r 5d20d2f6ffed -r 94b89a5f14e5 tools/libxl/libxl_types.idl
--- a/tools/libxl/libxl_types.idl
+++ b/tools/libxl/libxl_types.idl
@@ -175,6 +175,7 @@ libxl_dominfo = Struct("dominfo",[
     ("shutdown_reason", libxl_shutdown_reason),
     ("current_memkb",   MemKB),
     ("shared_memkb", MemKB),
+    ("paged_memkb", MemKB),
     ("max_memkb",   MemKB),
     ("cpu_time",    uint64),
     ("vcpu_max_id", uint32),



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel