[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4 of 8 v2] autoconf: run libuuid test under Linux only

Roger Pau Monné writes ("Re: [Xen-devel] [PATCH 4 of 8 v2] autoconf: run 
libuuid test under Linux only"):
> -luuid is only used when building under Linux (see
> tools/libxl/Makefile for example), NetBSD uuid lib is different from
> linux, and doesn't require the -luuid flag to link, it doesn't even
> have the same API. Since we already check for different uuid headers
> in Linux/NetBSD, what about this:

I think we should change the existing code:

>  [if test "x$host_os" == "xlinux-gnu"
>  then
>      AC_CHECK_HEADER([uuid/uuid.h],,
> -         [AC_MSG_ERROR([cannot find uuid headers])])
> +        [AC_MSG_ERROR([cannot find uuid headers])])
> +    AC_CHECK_LIB([uuid], [uuid_clear], [],
> +        [AC_MSG_ERROR([cannot find libuuid])])

I realise that this is how it was done pre-autoconf, but really I
think that all tests on $host_os are wrong in principle.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.