[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libxl: don't accept negative disk or partition indexes

>>> On 07.03.12 at 20:36, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Wed, 2012-03-07 at 06:01 -0500, Jan Beulich wrote:
>> When obtained via sscanf(), they were checked against an upper bound
>> only so far. By converting the local variables' types to "unsigned int"
>> those bounds checks become sufficient (as a consequence the helper
>> function's parameter types need to be adjusted too). It's not strictly
>> necessary to also convert libxl__device_disk_dev_number()'s parameter
>> types - 
> Any reason not to do it though?

I wanted to keep the patch to the minimum. The pointed out possible
cleanup I'd rather leave to those more involved with that code...


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.