[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] x86/vMCE: save/restore MCA capabilities

Jan Beulich wrote:
>>>> On 05.03.12 at 21:19, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:
>> Another question is, why in the patch mcg_cap defined as per vcpu
>> while others (mcg_ctl/ mcg_status/ mci_ctl) defined as per domain?
>> Semantically it looks some weird anyway.
> That question goes back to you (as a company), who wrote the
> original code: Why were these made per-domain in the first place
> when they're really per-vCPU? All I did here is make per-vCPU
> what I needed to touch anyway for save/restore (in order to not
> carry over the same mistake into the save/restore definitions and
> logic).
> Jan

Per my understanding, the original design may think that per vcpu mca msr is 
not necessary: vcpu are not 1:1 w/ pcpu, and multi-copies of same error info 
(if per vcpu) is pointless, so it designed as per domain, as long as it 
successfully emulated mca msr for guest.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.