[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Core parking feature enable

>>> On 04.03.12 at 16:48, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:
> Yes, it does need to intercept ACPI PAD notify then handle it similar way as 
> native kernel did. The logic is at dom0 '[PATCH 3/3] Xen pad logic and 
> notification' as attached.

And I know now why I didn't look at this in any detail - it modifies a
file that doesn't even exist in 3.3-rc5 (drivers/xen/xen_acpi_pad.c),
nor does it mention what tree/branch this would be against. Plus,
ACPI_PROCESSOR_AGGREGATOR is a tristate symbol, yet your code
assumes it to be boolean.

But yes, given the way this is implemented I withdraw my reservations
against the hypervisor side changes, as doing this completely in the
Dom0 kernel would be cumbersome (due to the need to call sysctl
functions), and doing it entirely in user space would indeed only be
justified if the native kernel did it this way too.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.