Re: [Xen-devel] Need help with qemu args debug

[Philipp Hahn <hahn@xxxxxxxxxxxxx>]

Hi,

just a nit:

On Wednesday 29 February 2012 12:22:35 Ian Campbell wrote:
> What I often do is create qemu-debug.sh:
>       #!/bin/sh
>       echo "Starting QEMU with: $*" >> /tmp/qemu-dbg.log
>       exec /usr/lib/xen/bin/qemu-system-i386 $@

You should always put double-quotes arount the $@, otherwise the shell does 
IFS-splitting on the arguments. Probably not that important in this case, but 
since this creates nasty quoting problems in general, post "good code" for 
the archive.

Sincerely
Philipp

PS: I know there are broken shell, which don't handle "$@" correct, but hey, 
they're broken anyway.
-- 
Philipp Hahn           Open Source Software Engineer      hahn@xxxxxxxxxxxxx
Univention GmbH        Linux for Your Business        fon: +49 421 22 232- 0
Mary-Somerville-Str.1  D-28359 Bremen                 fax: +49 421 22 232-99
                                                   http://www.univention.de/

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel