Re: [Xen-devel] make install not creating lib entries in /usr/lib under Ubunu 11.10

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-02-29 at 10:18 +0000, Roger Pau Monnà wrote:
> 2012/2/28 Ian Campbell <Ian.Campbell@xxxxxxxxxx>:
> > On Tue, 2012-02-28 at 17:51 +0000, Jeffrey Karrels wrote:
> >
> >> > Have you changed anything here or are you saying that a pristine Xen
> >> > tree when built on CentOS installs 64 bit libraries to /usr/lib instead
> >> > of /usr/lib64? If so please can you be precise about what tree you are
> >> > running (e.g. the exact URL you cloned and which changeset you got) and
> >> > steps you took to install (e.g. what patches did you apply, what
> >> > commands did you type) and what exactly you saw (e.g. what was
> >> > in /usr/lib and what was in /usr/lib64)
> >>
> >> #uname -a
> >> Linux xenbuild2.cyberlab 2.6.32-220.4.1.el6.x86_64 #1 SMP Tue Jan 24
> >> 02:13:44 GMT 2012 x86_64 x86_64 x86_64 GNU/Linux
> >>
> >> #hg clone -r 24869 http://xenbits.xen.org/hg/xen-unstable.hg
> >> #cd xen-unstable
> >> #./configure --enable-xsm --libdir=/usr/lib64
> >
> > OK, so you are using something new enough to have the autoconf stuff --
> > I think this is simply a bug in that. I've CC'd Roger.
> >
> > Ideally configure would auto-detect the right thing for the given system
> > and so --libdir would not be required. This would certainly be n
> > improvement over the pre-autoconf thing.
> 
> configure was not properly parsing the libdir path and always set it
> to "lib", this is a fix:

Thanks.

> 8<--------------------------------------------
> 
> autoconf: fix libdir detection
> 
> If user specifies a libdir it is used, if no libdir is specified
> configure checks if $prefix/lib64 is a directory and uses that, if not
> lib is used.

The code seems to use both ${exec_prefix} and ${prefix} is that correct?
Seems like an odd place to set \$prefix is all.

> diff -r 4758a7a94c15 tools/m4/default_lib.m4
> --- a/tools/m4/default_lib.m4 Wed Feb 22 04:46:07 2012 +0100
> +++ b/tools/m4/default_lib.m4 Wed Feb 22 06:31:53 2012 +0100
> @@ -1,8 +1,12 @@
>  AC_DEFUN([AX_DEFAULT_LIB],
> -[AS_IF([test -d "$prefix/lib64"], [
> -    LIB_PATH="lib64"
> -],[
> -    LIB_PATH="lib"
> +[AS_IF([test "\${exec_prefix}/lib" = "$libdir"],
> +    [AS_IF([test "$prefix" = "NONE"], [prefix=$ac_default_prefix])
> +    AS_IF([test -d "${prefix}/lib64"], [
> +        LIB_PATH="lib64"
> +    ],[
> +        LIB_PATH="lib"
> +    ])
> +], [
> +    LIB_PATH="${libdir:`expr length "$exec_prefix" + 1`}"
>  ])
>  AC_SUBST(LIB_PATH)])
> -



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel