Re: [Xen-devel] [PATCH] Add optionals build configs for qemu upstream

[Roger Pau Monnà <roger.pau@xxxxxxxxxxxxx>]

2012/2/28 Fabio Fantoni <fantonifabio@xxxxxxxxxx>:
> Add optionals build configs for qemu upstream:
> CONFIG_QEMUU_DEBUG for enable debug, disabled by default
> CONFIG_QEMUU_SPICE for enable spice, disabled by default for now
> Add to README requirements for spice enabled
>
> Signed-off-by: Fabio Fantoni <fabio.fantoni@xxxxxxxxxx>
>
> diff --git a/Config.mk b/Config.mk
> index bc6be65..918aa7b 100644
> --- a/Config.mk
> +++ b/Config.mk
> @@ -203,6 +203,8 @@ ETHERBOOT_NICS ?= rtl8139 8086100e
> ÂCONFIG_OVMF ?= n
> ÂCONFIG_ROMBIOS ?= y
> ÂCONFIG_SEABIOS ?= y
> +CONFIG_QEMUU_DEBUG ?= n
> +CONFIG_QEMUU_SPICE ?= n

It will be nice to add this as configure options, so a user can pass
"--enable-qemu-debug" or "--enable-qemu-spice" to configure and the
proper flags are set on the generated config/Tools.mk instead of
setting them directly on .config or Config.mk. There are some examples
of this on tools/configure.ac.

>
> Â# Specify which qemu-dm to use. This may be `ioemu' to use the old
> Â# Mercurial in-tree version, or a local directory, or a git URL.diff --git
> a/README b/README
> index b15a59b..fdb5e3a 100644
> --- a/README
> +++ b/README
> @@ -60,6 +60,8 @@ provided by your OS distributor:
> Â Â * 16-bit x86 assembler, loader and compiler (dev86 rpm or bin86 & bcc
> debs)
> Â Â * ACPI ASL compiler (iasl)
> Â Â * markdown
> + Â Â* if CONFIG_QEMUU_SPICE=y Dev of spice protocol (e.g.
> libspice-protocol-dev)
> + Â Â ÂDev of spice server (e.g. libspice-server-dev >=0.10)
>
> ÂSecond, you need to acquire a suitable kernel for use in domain 0. If
> Âpossible you should use a kernel provided by your OS distributor. Ifdiff
> --git a/tools/Makefile b/tools/Makefile
> index 6430bfb..eceecb2 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -87,6 +87,14 @@ IOEMU_CONFIGURE_CROSS ?= --cpu=$(XEN_TARGET_ARCH) \
> Â Â Â Â Â Â Â--interp-prefix=$(CROSS_SYS_ROOT)
> Âendif
>
> +ifeq ($(CONFIG_QEMUU_DEBUG),y)
> +QEMU_OPTIONAL_CONFIGS += --enable-debug
> +endif
> +
> +ifeq ($(CONFIG_QEMUU_SPICE),y)
> +QEMU_OPTIONAL_CONFIGS += --enable-spice
> +endif
> +
> ÂQEMU_ROOT := $(shell if [ -d "$(CONFIG_QEMU)" ]; then echo
> "$(CONFIG_QEMU)"; else echo .; fi)
> Âifneq ($(QEMU_ROOT),.)
> Âexport QEMU_ROOT
> @@ -158,6 +166,7 @@ subdir-all-qemu-xen-dir subdir-install-qemu-xen-dir:
> qemu-xen-dir-find
> Â Â Â Â --disable-kvm \
> Â Â Â Â --python=$(PYTHON) \
> Â Â Â Â $(IOEMU_CONFIGURE_CROSS); \
> + Â Â Â Â$(QEMU_OPTIONAL_CONFIGS); \
> Â Â $(MAKE) install
>
> Âsubdir-clean-qemu-xen-dir:
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel