Re: [Xen-devel] [PATCH] tools: fix python version checking issue

[Roger Pau Monnà <roger.pau@xxxxxxxxxxxxx>]

2012/2/25 Ren, Yongjie <yongjie.ren@xxxxxxxxx>:
> Even if python version is 2.4.3 which is newer than the required version 2.3, 
> the configure script still raises a version issue.
> I tested my patch with python 2.6.6 and 2.4.3. It will fix a syntax error 
> like the following.
> checking for python version >= 2.3 ... Traceback (most recent call last):
> ÂFile "<string>", line 1, in ?
> TypeError: 'str' object is not callable
> no
> configure: error: Python 2.4.3 is too old, minimum required version is 2.3
>
> Signed-off-by: Yongjie Ren <yongjie.ren@xxxxxxxxx>

Acked-by: Roger Pau Monne <roger.pau@xxxxxxxxxxxxx>

Provided that the following is applied after, output from autoconf:

8<--------------------------------------------

autoconf: rerun autoconf

Rerun autoconf to generate new configure script with python version
checking fix.

Signed-off-by: Roger Pau Monne <roger.pau@xxxxxxxxxxxxx>

diff -r 8916d782ba27 tools/configure
--- a/tools/configure   Tue Feb 21 22:28:03 2012 +0100
+++ b/tools/configure   Tue Feb 21 22:30:03 2012 +0100
@@ -6293,7 +6293,7 @@ then
 fi
     { $as_echo "$as_me:${as_lineno-$LINENO}: checking for python
version >= 2.3 " >&5
 $as_echo_n "checking for python version >= 2.3 ... " >&6; }
-`$PYTHON -c 'import sys; exit(eval("sys.version_info < (2, 3)"))'`
+`$PYTHON -c 'import sys; sys.exit(eval("sys.version_info < (2, 3)"))'`
 if test "$?" != "0"
 then
     python_version=`$PYTHON -V 2>&1`

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel