Re: [Xen-devel] [PATCH 1 of 2] Linux/init: check for brctl at xencommons

[Roger Pau Monnà <roger.pau@xxxxxxxxxxxxx>]

2012/2/24 Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>:
> Roger Pau Monne writes ("[PATCH 1 of 2] Linux/init: check for brctl at 
> xencommons"):
>> Linux/init: check for brctl at xencommons
> ...
>> +# Check if brctl is present
>> +hash brctl > /dev/null 2>&1 || echo "Warning: brctl not found"

(this is a previous version of the patch, see
http://lists.xen.org/archives/html/xen-devel/2012-02/msg02108.html for
the new series)

> I using think "type" would be more idomatic than "hash".

Ok, I will replace hash with type

> I think the warning message should go to stderr and mention
> xencommons. ÂI was going to suggest that you should use the lsb init
> function "log_warning_msg" but I see that xencommons does not
> currently source /lib/lsb/init-functions. ÂBut perhaps it should.

I usually use OpenRC under Linux, and since it doesn't like the stock
xencommons file I use a custom one. If you think it is ok to include
/lib/lsb/init-functions I can update the series to include that and
make use of log_warning_msg.

> http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptfunc.html
>
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel