Re: [Xen-devel] [PATCH 6 of 7] x86/mm: Clean up mem event structures on domain destruction

[Olaf Hering <olaf@xxxxxxxxx>]

On Thu, Feb 23, Andres Lagar-Cavilla wrote:

> +++ b/xen/include/asm-arm/mm.h
> @@ -266,7 +266,8 @@ int  get_page(struct page_info *page, st
>          machine_to_phys_mapping[(mfn)] = (pfn);                \
>      })
>  
> -#define put_gfn(d, g)   ((void)0)
> +#define put_gfn(d, g)           ((void)0)
> +#define mem_event_cleanup(d)    ((void)0)
>  
>  #define INVALID_MFN             (~0UL)
>  
> diff -r 9c6cbbe72dc4 -r 1a76b2f7641b xen/include/asm-ia64/mm.h
> --- a/xen/include/asm-ia64/mm.h
> +++ b/xen/include/asm-ia64/mm.h
> @@ -551,7 +551,8 @@ extern u64 translate_domain_pte(u64 ptev
>      gmfn_to_mfn_foreign((_d), (gpfn))
>  
>  #define get_gfn_untyped(d, gpfn) gmfn_to_mfn(d, gpfn)
> -#define put_gfn(d, g)   ((void)0)
> +#define put_gfn(d, g)           ((void)0)
> +#define mem_event_cleanup(d)    ((void)0)

This is C, not cpp, so these should have been like this in the first place:

static inline int foo( .... ) { return 0; }


Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel