Re: [Xen-devel] [PATCH 10 of 10] xl: Implement sched-credit schedule parameter command-line interface

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

George Dunlap writes ("[Xen-devel] [PATCH 10 of 10] xl: Implement sched-credit 
schedule parameter command-line interface"):
> Add features to the sched-credit interface to allow querying and
> displaying scheduler parameters.  New interface works as follows:
> 
>  <nothing>             : List all domain params and sched params from all 
> pools
>  -d [domid]            : List domain params for domain
>  -d [domid] [params]   : Set domain params for domain
>  -p [pool]             : list all domains and sched params for pool
>  -s                    : List sched params for poolid 0
>  -s [params]           : Set sched params for poolid 0
>  -p [pool] -s          : List sched params for pool
>  -p [pool] -s [params] : Set sched params for pool
>  -p [pool] -d...       : Illegal

This information should be in the xl manpage, rather than in the
commit message and a code comment.

> +static int sched_credit_param_set(
> +    int poolid, libxl_sched_credit_param *scinfo)
> +{

Formatting.  It should be

static int sched_credit_param_set(int poolid, libxl_sched_credit_param *scinfo)

(79 columns) or

static int sched_credit_param_set(int poolid,
                                  libxl_sched_credit_param *scinfo)

(67 columns).

This should be changed throughout I'm afraid.

> +        } else { /* Set scheduling parameters*/
> +            rc = sched_credit_param_get(poolid, &scparam);

What happens if the pool isn't using the credit scheduler ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel