Re: [Xen-devel] [PATCH 09 of 10] xl: Refactor sched_domain_output to have a callback for pool information

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

George Dunlap writes ("[Xen-devel] [PATCH 09 of 10] xl: Refactor 
sched_domain_output to have a callback for pool information"):
> Allow a scheduler to provide a callback to display pool-wide information,
> providing a default.  This is in preparation for displaying pool-wide
> scheduler parameters on this line.

> +static int sched_default_pool_output(
> +    uint32_t poolid)
> +{

Formatting glitch.  I know sched_domain_output looks like that but
that's because it needs it to avoid wrapping.

>  static int sched_domain_output(
> -    uint32_t sched, int (*output)(int), const char *cpupool)
> +    uint32_t sched, int (*output)(int), int (*pooloutput)(uint32_t), const 
> char *cpupool)

And here you've failed to wrap it :-).  I suggest

  static int sched_domain_output(uint32_t sched, const char *cpupool,
                int (*output)(int), int (*pooloutput)(uint32_t))
  {

but anything plausible is fine by me.

Aside from those niggles,

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel