Re: [Xen-devel] [PATCH v4 2/7] arm: compile libxc

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-02-21 at 15:17 +0000, Ian Campbell wrote:
> On Wed, 2012-02-15 at 12:24 +0000, Stefano Stabellini wrote:
> > 
> > +static int
> > +xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context
> > *dinfo, xc_dominfo_t *info,
> > +                        shared_info_any_t *live_shinfo, xen_pfn_t
> > **live_p2m,
> > +                        unsigned long *pfnp, int rw)
> > +{
> > +    return -ENOSYS;
> 
> I only just noticed this: libxc is supposed to set errno and return -1,
> not return -Efoo.
> 
> There's a few of these in this series. I actually noticed it in
> xc_hvm_build_arm.c but this was the first one I came across when
> grepping my mail.

If you are resending, could you also add the emacs magic comments to the
tail of any new files.

Thanks,
Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel