Re: [Xen-devel] [PATCH 15 of 23] libxl: make boolean members of libxl_domain_create_info into libxl_defbool

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-02-20 at 19:25 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[Xen-devel] [PATCH 15 of 23] libxl: make boolean 
> members of libxl_domain_create_info into libxl_defbool"):
> > libxl: make boolean members of libxl_domain_create_info into libxl_defbool

NB: should have said build_info here.

> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> > +        libxl_defbool_setdefault(&b_info->u.hvm.pae, true);
> > +        libxl_defbool_setdefault(&b_info->u.hvm.apic, true);
> > +        libxl_defbool_setdefault(&b_info->u.hvm.acpi, true);
> > +        libxl_defbool_setdefault(&b_info->u.hvm.acpi_s3, true);
> > +        libxl_defbool_setdefault(&b_info->u.hvm.acpi_s4, true);
> > +        libxl_defbool_setdefault(&b_info->u.hvm.nx, true);
> > +        libxl_defbool_setdefault(&b_info->u.hvm.viridian, false);
> > +        libxl_defbool_setdefault(&b_info->u.hvm.hpet, true);
> > +        libxl_defbool_setdefault(&b_info->u.hvm.vpt_align, true);
> > +        libxl_defbool_setdefault(&b_info->u.hvm.nested_hvm, false);
> > +        libxl_defbool_setdefault(&b_info->u.hvm.usb, false);
> > +        libxl_defbool_setdefault(&b_info->u.hvm.xen_platform_pci, true);
> 
> Maybe this would be easier to read like this:
> 
>  +        libxl_defbool_setdefault(&b_info->u.hvm.nested_hvm,       false);
>  +        libxl_defbool_setdefault(&b_info->u.hvm.usb,              false);
>  +        libxl_defbool_setdefault(&b_info->u.hvm.xen_platform_pci, true);

Seems like an improvement. I'll make that change.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xensource.com/xen-devel