Re: [Xen-devel] [PATCH 4 of 6 V4] libxl: support suspend_cancel in domain_resume

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 20 Feb 2012, Shriram Rajagopalan wrote:
> On Mon, Feb 20, 2012 at 11:00 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> 
> wrote:
>       rshriram@xxxxxxxxx writes ("[Xen-devel] [PATCH 4 of 6 V4] libxl: 
> support suspend_cancel in domain_resume"):
>       > libxl: support suspend_cancel in domain_resume
> 
> I get this:
> 
> libxl.c: In function 'libxl_domain_resume':
> libxl.c:315: error: implicit declaration of function 
> 'libxl__domain_resume_device_model'
> 
> Did you compile this ? ÂDid you test it ?
> 
> 
> Yes I did.. Did you apply the previous patch in this series, that introduces 
> the above (missing)Â function ?
> 
> As I mentioned in the introductory email, these patches also depend on 
> Stefano's XC_SAVE_ID_TOOLSTACK patches.
> 
> 01 Introduce a new save_id to save/restore toolstack specific extra
> 02 Read Qemu's physmap from xenstore and save it using toolstack_save.
> 03 Following the recent changes to upstream Qemu, the best monitor command
> ÂÂÂ (removes qmp_migrate and introduces qmp_save)
> 
> 
> Then my patches:
> 03 libxl: QMP stop/resume & refactor QEMU suspend/resume/save
> 04 libxl: support suspend_cancel in domain_resume
> 05 libxl: refactor migrate_domain and generalize migrate_receive
> 06 libxl: resume instead of unpause on xl save -c
> 
> 01 libxl: Remus - suspend/postflush/commit callbacks
> 02 libxl: Remus - xl remus command
> 
> Currently, one of stefano's patches doesnt apply cleanly - the first one. It 
> requires minor fix.
> Barring that, all the other patches mentioned above apply cleanly.
> 

I can rebase and resend if it is needed.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xensource.com/xen-devel