Re: [Xen-devel] [PATCH] libxl_qmp: Handle unexpected end-of-socket

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Mon, Feb 20, 2012 at 17:09, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Anthony PERARD writes ("[Xen-devel] [PATCH] libxl_qmp: Handle unexpected 
> end-of-socket"):
>> When read() return 0, the current code just tries again. But this leads to an
>> infinite loop if QEMU died too soon.
>
> Right.
>
>> Also, retry select if a signal was caught.
>
> Why add another goto ? ÂI think these goto-based loops are a bad idea,
> really.
>
>> + Â Â Â Â Â Âif (errno == EINTR)
>> + Â Â Â Â Â Â Â Âgoto do_select_again;
>
> I think this could be "continue". ÂDo you agree.

Yes, I agree. I'll change that for a while and resend it.

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xensource.com/xen-devel