[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] fix build error

Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] [PATCH] fix build error"):
> On Thu, Jan 05, 2012 at 03:05:21PM +0000, Ian Campbell wrote:
> > Any patch which says "fix build error/warning/message" should, IMHO,
> > always include a verbatim copy of the error message being fixed.


> > Please can one of you resubmit with the changelog corrected in that
> > manner?
> Yes please. You can also add 'Tested-by: Konrad Rzeszutek Wilk
> <konrad.wilk@xxxxxxxxxx>'. Thanks.

This doesn't seem to have been forthcoming and it was all pretty
obvious following this thread so I've committed it now.
Next time it would definitely be nice if we could have a good commit
message and so forth.

> > Eventually we could use autoconf to detect this stuff, although that
> > does sound rather like overkill...

This kind of irritating API instability is exactly what autoconf is
good at.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.