Re: [Xen-devel] [SeaBIOS] SeaBIOS build problem

[Roger Pau Monnà <roger.pau@xxxxxxxxxxxxx>]

2012/2/20 Kevin O'Connor <kevin@xxxxxxxxxxxx>:
> On Mon, Feb 20, 2012 at 09:48:48AM +0000, Ian Campbell wrote:
>> On Mon, 2012-02-20 at 09:22 +0000, Roger Pau Monnà wrote:
>> > When looking into gen-offsets.sh [0] I've realized there's a strange
>> > shebang in the script ":", is this normal? Replacing ":" with
>> > "#!/bin/sh" solves the problem, but I don't understand why the ":"
>> > shebang works for some (on Debian stable it works ok) and what it
>> > means.
>>
>> I've no idea either -- I've copied the seabios ML.
>
> It's an old-style way of indicating the file is a shell script. ÂI
> wasn't aware this creeped in there - it should be converted to the
> more standard style.
>
> -Kevin
>
>
> commit 0fd9953a538b22e6087f9d4f25749e3622e40e87
> Author: Kevin O'Connor <kevin@xxxxxxxxxxxx>
> Date: Â Mon Feb 20 09:33:23 2012 -0500
>
> Â ÂUse "#!/bin/sh" instead of ":" in tools/gen-offsets.sh.
>
> Â ÂSigned-off-by: Kevin O'Connor <kevin@xxxxxxxxxxxx>

Don't know if it's ok to Ack this, if not please ignore it and
consider this a Tested-by:

Acked-by: Roger Pau Monnà <roger.pau@xxxxxxxxxxxxx>

>
> diff --git a/tools/gen-offsets.sh b/tools/gen-offsets.sh
> index 99fdc53..73dede8 100755
> --- a/tools/gen-offsets.sh
> +++ b/tools/gen-offsets.sh
> @@ -1,4 +1,4 @@
> -:
> +#!/bin/sh
> Â# Extract definitions from an assembler file. ÂThis is based on code
> Â# from the Linux Kernel.
> ÂINFILE=$1

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel