Re: [Xen-devel] [PATCH v2 07/10] arm: compile libxl

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 13 Feb 2012, Ian Jackson wrote:
> Stefano Stabellini writes ("[Xen-devel] [PATCH v2 07/10] arm: compile libxl"):
> > libxl_cpuid_destroy has been renamed to libxl_cpuid_dispose; also cpuid
> > functions are only available on x86, so ifdef the new cpuid related
> > function in libxl_json.c.
> ...
> > +#if defined(__i386__) || defined(__x86_64__)
> >  yajl_gen_status libxl_cpuid_policy_list_gen_json(yajl_gen hand,
> >                                  libxl_cpuid_policy_list *pcpuid)
> >  {
> > @@ -199,6 +200,13 @@ empty:
> >  out:
> >      return s;
> >  }
> > +#else
> > +yajl_gen_status libxl_cpuid_policy_list_gen_json(yajl_gen hand,
> > +                                libxl_cpuid_policy_list *pcpuid)
> > +{
> > +    return 0;
> > +}
> > +#endif
> 
> Again, can't this be moved to libxl_{no,}cpuid.c ?

Yes, it can.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel